fix(service-settings): remove legacy buildAuditSink that wrote to sys_audit_log with wrong columns#2017
Merged
Merged
Conversation
…_audit_log with wrong columns Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 5 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildAuditSinkinSettingsServicePluginwas inserting intosys_audit_logwith columns that don't exist on that table (actor_id,entity_type,entity_id,payload,occurred_at). This caused aSqliteErroron every settings write, caught silently and emitted as aWARN SettingsServicePlugin: audit record failedlog.buildAuditWriter(already wired in the samebindEnginecall) correctly writes tosys_setting_auditwith the proper schema.buildAuditSinkentirely and passundefinedfor the legacy audit sink slot.Root cause
The
sys_audit_logobject schema definesuser_id(notactor_id) and has noentity_type,entity_id,payload, oroccurred_atcolumns.buildAuditSinkwas written beforesys_setting_auditexisted and was never updated when Phase 3 introduced the dedicated table.Test plan
examples/app-crmand write a setting via the Setup UI — confirm noWARN SettingsServicePlugin: audit record failedin the consolesys_setting_auditrows are written correctly after a settings save🤖 Generated with Claude Code